Skip to content

fix(amazonq): increase node memory size to 8G #7528

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 19, 2025
Merged

fix(amazonq): increase node memory size to 8G #7528

merged 1 commit into from
Jun 19, 2025

Conversation

@yueny2020
Copy link
Contributor

@yueny2020 yueny2020 commented Jun 19, 2025

Problem

  • large repo has OOM exception when init
FATAL ERROR: Reached heap limit Allocation failed - JavaScript heap out of memory
 1: 0xb9bbf0 node::Abort() [Amazon Q Helper (Workspace Context)]
 2: 0xaa27ee  [Amazon Q Helper (Workspace Context)]
 3: 0xd734a0 v8::Utils::ReportOOMFailure(v8::internal::Isolate*, char const*, bool) [Amazon Q Helper (Workspace Context)]
 4: 0xd73847 v8::internal::V8::FatalProcessOutOfMemory(v8::internal::Isolate*, char const*, bool) [Amazon Q Helper (Workspace Context)]
 5: 0xf50c55  [Amazon Q Helper (Workspace Context)]
 6: 0xf6312d v8::internal::Heap::CollectGarbage(v8::internal::AllocationSpace, v8::internal::GarbageCollectionReason, v8::GCCallbackFlags) [Amazon Q Helper (Workspace Context)]
 7: 0xf3d81e v8::internal::HeapAllocator::AllocateRawWithLightRetrySlowPath(int, v8::internal::AllocationType, v8::internal::AllocationOrigin, v8::internal::AllocationAlignment) [Amazon Q Helper (Workspace Context)]
 8: 0xf3ebe7 v8::internal::HeapAllocator::AllocateRawWithRetryOrFailSlowPath(int, v8::internal::AllocationType, v8::internal::AllocationOrigin, v8::internal::AllocationAlignment) [Amazon Q Helper (Workspace Context)]
 9: 0xf1fdea v8::internal::Factory::NewFillerObject(int, v8::internal::AllocationAlignment, v8::internal::AllocationType, v8::internal::AllocationOrigin) [Amazon Q Helper (Workspace Context)]
10: 0x12e505f v8::internal::Runtime_AllocateInYoungGeneration(int, unsigned long*, v8::internal::Isolate*) [Amazon Q Helper (Workspace Context)]
11: 0x1711cb9  [Amazon Q Helper (Workspace Context)]
[Info  - 7:59:05 PM] Connection to server got closed. Server will restart.
[Info  - 7:59:05 PM] Error occurred during chat request: Error: Connection got disposed.
[Info  - 7:59:05 PM] Last result from langauge server: undefined

Solution

  • increase node memory size to 8G
  • tested with a local build
2025-06-18 04:59:37.485 [info] Command: (not started) [/opt/vsc-sysroot/lib/ld-linux-x86-64.so.2 --library-path /opt/vsc-sysroot/lib/ /home/isalan/.cache/aws/toolkits/language-servers/AmazonQ/1.13.0/servers/node --max-old-space-size=8196 /home/isalan/.cache/aws/toolkits/language-servers/AmazonQ/1.13.0/servers/aws-lsp-codewhisperer.js --nolazy --preserve-symlinks --stdio --pre-init-encryption --set-credentials-encryption-key]
  • Treat all work as PUBLIC. Private feature/x branches will not be squash-merged at release time.
  • Your code changes must meet the guidelines in CONTRIBUTING.md.
  • License: I confirm that my contribution is made under the terms of the Apache 2.0 license.

@yueny2020 yueny2020 requested a review from a team as a code owner June 19, 2025 03:02
@github-actions
Copy link

github-actions bot commented Jun 19, 2025

  • This pull request modifies code in src/* but no tests were added/updated.
    • Confirm whether tests should be added or ensure the PR description explains why tests are not required.
  • This pull request implements a feat or fix, so it must include a changelog entry (unless the fix is for an unreleased feature). Review the changelog guidelines.
    • Note: beta or "experiment" features that have active users should announce fixes in the changelog.
    • If this is not a feature or fix, use an appropriate type from the title guidelines. For example, telemetry-only changes should use the telemetry type.

leigaol
leigaol reviewed Jun 19, 2025
View reviewed changes
packages/core/src/shared/lsp/utils/platform.ts
return async () => {
const bin = executable[0]
const args = [...executable.slice(1), serverModule, ...execArgv]
const args = [...executable.slice(1), '--max-old-space-size=8196', serverModule, ...execArgv]
Copy link
Contributor

@leigaol leigaol Jun 19, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please test this in AL2.

Copy link
Contributor Author

@yueny2020 yueny2020 Jun 19, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i asked the one user tested a local build. His Operating System is Amazon Linux 2 x86_64 5.10 Kernel (Cloud Desktop)

Copy link
Contributor

@leigaol leigaol Jun 19, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes you can also test it using your own AL2 instances

Copy link
Contributor Author

@yueny2020 yueny2020 Jun 19, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i also test it using my own dev desktop.

@yueny2020 yueny2020 merged commit a73ba2b into aws:master Jun 19, 2025
31 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@leigaol leigaol leigaol approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@yueny2020 @leigaol